search

Benjamin-Dobell / IntelliJ-Luanalysis

Type-safe Lua IDE — IntelliJ IDEA plugin
Apache License 2.0
155 stars 21 forks source link

resolve some deprecations, upgrade to 2022.3 #137

Closed Xseba360 closed 1 year ago

Xseba360 commented 2 years ago

These are my attempts at understanding Java and Kotlin. For now, pretty much limited to fixing IDE warnings/errors about deprecation and such. I managed to make it compatible with 2022.2.2 IDEs. Really like this plugin, so I'm trying to help in a pretty basic way. :). More commits will be added soon, so I'm making a draft pull request for now.

Xseba360 commented 1 year ago

I didn't have time to work on this PR recently, but is this still useful? @Benjamin-Dobell ?

Benjamin-Dobell commented 1 year ago

I haven't gone through and made these same changes, although most of it looks pretty straight-forward. That said, it'd be a lot easier to get this stuff in if it's split up a bit more. I mean, honestly, if I was implementing it myself, I'd probably do similar to you. But that's because I don't need to get it reviewed by anyone 😆

If you want, you're quite welcome to rebase, and maybe split it up. But also, that's a lot of work and I'm happy to do this same stuff at some point down the track.