Fix broken list item bullet type option

Benjamin-Dobell / react-native-markdown-view

MarkdownView for React Native

MIT License

190 stars 77 forks source link

Fix broken list item bullet type option #15

Closed Matthewnie closed 4 years ago

Matthewnie commented 6 years ago

listItemBullet.content throws a warning for failed prop type on the styling and does not change the bullet type. Changed to listItemBulletType.content to only be used for the overriding of the Bullet Type, now overrides the bullet type.

Benjamin-Dobell commented 4 years ago

I'm pretty sure this change is incorrect at present, but may well have been valid when it was submitted a long time ago. So I'm closing this PR, but if some such problem still exists, please open a issue describing the problem. Thanks.

alexking commented 2 years ago

Believe this is still an issue, Failed prop type: Invalid props.style key content supplied to Text when using this, and it seems to keep it from changing the bullet point as well. We probably need to pull the content property out before we pass it to Text.