Benjamin-Dobell / react-native-markdown-view

MarkdownView for React Native
MIT License
190 stars 77 forks source link

Content partially not showing #3

Closed dancomanlive closed 7 years ago

dancomanlive commented 7 years ago

screen shot 2017-07-17 at 12 19 28 pm

dancomanlive commented 7 years ago

This only happens once every few tries btw.

<MarkdownView
          onLinkPress={url => Linking.openURL(url)}
          style={{ paddingHorizontal: 10 }}
          styles={{
            image: {
              marginLeft: -10,
              resizeMode: 'contain',
            },
            imageWrapper: {
              width,
              padding: 0
            },
            paragraph: {
              marginTop: 10,
              marginBottom: 10,
            }
          }}
        >
          {section.value}
 </MarkdownView>
Benjamin-Dobell commented 7 years ago

Could you please include an example of the Markdown text (section.value) that should be rendered?

Also, given you've described this as intermittent, a screenshot of rendering working vs. not working would be ideal.

It's hard to tell with limited information, but I would expect this sort of behaviour to be the result of an application bug (async race condition etc.), although I could be wrong. Where is section.value coming from?

dancomanlive commented 7 years ago

Thanks for the quick reply. The issue was due to fixed width and height of images. This was just fixed(see link to fork) to take the original width and height of the images https://github.com/LizardApps/react-native-markdown-view/commit/cc91c927fc09657fca9982bd015c1d97ce2a519c

Benjamin-Dobell commented 7 years ago

I'm closing this now as I think the issue may have specifically been with your styles/customisation. However, if that's not the case please comment here with an explanation and I'll re-open.