search

Benjamin-Dobell / react-native-markdown-view

MarkdownView for React Native
MIT License
190 stars 77 forks source link

Added check for space for heading tags. #43

Closed bvelasquez closed 4 years ago

bvelasquez commented 4 years ago

The #hashtag should not render as a H1 Header, but just normal typeface. The "# hastag" should render as a header on its own line. Added a space check in the regex.

bvelasquez commented 4 years ago

Do you merge any pull requests anymore? @Benjamin-Dobell

Benjamin-Dobell commented 4 years ago

Thanks for reporting this.

I'd like to fix this, unfortunately this pull request currently consists of 183 changes, where as it should be just a single character change i.e. replacing the * in the regex with +.

If you'd like to update your pull request accordingly, then I'll happily merge it. Otherwise, it's easy enough for me to make the change; just let me know.

bvelasquez commented 4 years ago

Still messing with the formatting, even after following your instruction. No newline for some reason.

Benjamin-Dobell commented 4 years ago

Manually merged https://github.com/Benjamin-Dobell/react-native-markdown-view/commit/c04986537e9faae5ef685eb254b7fd3e0b8d780b 😄

bvelasquez commented 4 years ago

Thank you! I've disabled prettier for any future git PR's. What a mess that was.

Barry

On Fri, Jan 31, 2020 at 10:10 AM Benjamin Dobell notifications@github.com wrote:

Manually merged c049865 https://github.com/Benjamin-Dobell/react-native-markdown-view/commit/c04986537e9faae5ef685eb254b7fd3e0b8d780b 😄

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Benjamin-Dobell/react-native-markdown-view/pull/43?email_source=notifications&email_token=AARSCAX5BH4Q5ASWDYRCLZ3RARSSPA5CNFSM4JHQWVSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKPQCLY#issuecomment-580845871, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARSCARQMJL2SINKHYOOVHLRARSSPANCNFSM4JHQWVSA .