search

Benjamin-Dobell / react-native-markdown-view

MarkdownView for React Native
MIT License
190 stars 77 forks source link

Headings do not respect passed margins #7

Closed gabceb closed 7 years ago

gabceb commented 7 years ago

If we add a heading 3 markdown element we can override things like color but not any of the margin styles. I have debugged this and we get all the correct styles for both heading and heading3 all the way to https://github.com/Benjamin-Dobell/react-native-markdown-view/blob/master/renders.js#L92-L100 but the node is not a string so the output function is called and we believe this one is not respecting the margins and instead is adding margin: 0 to the element

Let me know if I can provide any other information to help with this

gabceb commented 7 years ago

Thanks @Benjamin-Dobell and @ryank109