search

Benjamin-Dobell / react-native-markdown-view

MarkdownView for React Native
MIT License
190 stars 77 forks source link

Fixed heading style #8

Closed ryank109 closed 7 years ago

ryank109 commented 7 years ago

I went ahead and tried to fix #7.

It seemed like just removing the <Text> wrapper resolved the issue from what I can see. After removing the <Text>, it was almost same as textContentRenderer, so I refactored the code by removing textBlockRenderer.

@Benjamin-Dobell Do you see any problem with this change?

Benjamin-Dobell commented 7 years ago

@Benjamin-Dobell Do you see any problem with this change?

Not at all. Upon seeing #7 yesterday I came to the same realisation. I went to fix it and got a wee bit carried away trying to make general improvements on Android; because React Native doesn't support View nested in Text on Android. Turns out it's a really hard problem to solve!

Distractions aside, I'll merge this :)