search

BenjaminFavre / keycloak-apple-social-identity-provider

Apple Social Identity Provider for Keycloak
Apache License 2.0
108 stars 53 forks source link

modified for keycloak 7.0.1 #3

Open ivankovalenko opened 3 years ago

ivankovalenko commented 3 years ago

added russian translation

SalahAdDin commented 3 years ago

@BenjaminFavre What do you think about this?

@ivankovalenko there is a merging conflict here.

z0mb1ek commented 3 years ago

I think we shouldn't downgrade KC version and must make different versions of provider

BenjaminFavre commented 3 years ago

Sure, downgrading KC is not an option. Having multiple provider versions matching those of KC is an option, but is a lot of work. So I decided to only keep the provider up to date with the latest version of KC. Anyhow, the day Apple is officially integrated in KC, anyone willing to use it will have to upgrade KC (as for any new feature.) Somehow, having my provider working for the latest KC version is not more restrictive than that.

SalahAdDin commented 3 years ago

Sure, downgrading KC is not an option. Having multiple provider versions matching those of KC is an option, but is a lot of work. So I decided to only keep the provider up to date with the latest version of KC. Anyhow, the day Apple is officially integrated in KC, anyone willing to use it will have to upgrade KC (as for any new feature.) Somehow, having my provider working for the latest KC version is not more restrictive than that.

Is it officially integrated now? When since?

BenjaminFavre commented 3 years ago

No, not yet, there exists a PR ready to be merged but they have trouble to automate tests with Apple... I wanted to say "the day it will be intigrated in KC"