search

BenjaminFavre / keycloak-apple-social-identity-provider

Apple Social Identity Provider for Keycloak
Apache License 2.0
108 stars 53 forks source link

Add "Display Name" field to Admin UI snippet #5

Open netmikey opened 3 years ago

netmikey commented 3 years ago

According to this post, Apple requires a very specific wording for its Sign-In buttons. That would be easily achievable using the "Display Name" property present in the generic OIDC provider you're inheriting from. However, your Admin UI snippet is lacking that field. Could you please add the following snippet to realm-identity-provider-apple-ext.html as suggested by ebiscardi:

<div class="form-group clearfix">
   <label class="col-md-2 control-label" for="displayName"> {{:: 'display-name' | translate}}</label>
    <div class="col-md-6">
        <input class="form-control" id="displayName" type="text" ng-model="identityProvider.displayName">
    </div>
    <kc-tooltip>{{:: 'identity-provider.display-name.tooltip' | translate}}</kc-tooltip>
</div>
SalahAdDin commented 3 years ago

@netmikey Did you try to make a pull request?

netmikey commented 3 years ago

No I haven't, I have overwritten the whole realm-identity-provider-apple-ext.html in my project and have added those lines.

SalahAdDin commented 3 years ago

@netmikey It could be gread if you create a pull request to improve this repo.

SalahAdDin commented 3 years ago

@netmikey @BenjaminFavre It could be related to https://github.com/keycloak/keycloak/pull/7323#issuecomment-702828481