search

BenjaminFavre / keycloak-apple-social-identity-provider

Apple Social Identity Provider for Keycloak
Apache License 2.0
108 stars 53 forks source link

Example module.xml #7

Open asterix11 opened 3 years ago

asterix11 commented 3 years ago

Hi! Are you able to provide an example module.xml file? Currently I'm getting the following error: 16:08:35,049 ERROR [org.keycloak.services.error.KeycloakErrorHandler] (default task-2) Uncaught server error: java.lang.NoClassDefFoundError: javax/ws/rs/core/Response

My module.xml file:

<?xml version='1.0' encoding='UTF-8'?>

<module xmlns="urn:jboss:module:1.1" name="fr.benjaminfavre.provider">

    <resources>
        <resource-root path="provider.jar"/>
    </resources>

    <dependencies>
        <module name="org.keycloak.keycloak-core"/>
        <module name="org.keycloak.keycloak-server-spi"/>
        <module name="org.keycloak.keycloak-services"/>
        <module name="org.keycloak.keycloak-server-spi-private"/>
    </dependencies>
</module>
asterix11 commented 3 years ago

I tried to provide this dependency using another module.xml:

<?xml version='1.0' encoding='UTF-8'?>

<module xmlns="urn:jboss:module:1.1" name="javax.ws.rs-api">

    <resources>
        <resource-root path="provider.jar"/>
    </resources>

    <dependencies>
    </dependencies>
</module>

of course i provided the dependency to the "Apple Social Identity Provider" module using:

<module name="javax.ws.rs-api"/>

At first no errors occurred any more, but after trying to sign in nothing happens and the broker endpoint returned a 405.

asterix11 commented 3 years ago

I also included the "fr.benjaminfavre.provider" module in the standalone-ha.xml section specified in the README

asterix11 commented 3 years ago

Do you need more information to classify the issue?

SalahAdDin commented 3 years ago

@BenjaminFavre Are you still maintaining this?

SalahAdDin commented 3 years ago

I'm getting the a different problem with the same file: 15:18:14,920 FATAL [org.keycloak.services] (ServerService Thread Pool -- 63) Error during startup: java.lang.RuntimeException: org.jboss.modules.ModuleLoadException: Error loading module from /opt/jboss/keycloak/modules/fr/benjaminfavre/provider/main/module.xml.

BenjaminFavre commented 3 years ago

I work on the provider only when I need to upgrade my own Keycloak production server, sorry. For now, the provider works fine for me and other people, and I’m not sure the bug comes from the provider, maybe it is related to the way you install it and I am no help for the matter. I never had to modify module.xml, I just drop the jar in the deployments folder and it works. If you find the cause of your problem and it appears to be solvable by a fix in the provider code, please post a pull request and I will gratefully merge it. Check your Keycloak version too, current provider release works with Keycloak 11.0.2