BenjaminLHR / pe

0 stars 0 forks source link

Missing "X" to denote end of lifeline for Commands #15

Open BenjaminLHR opened 2 years ago

BenjaminLHR commented 2 years ago

Commands are not referenced again after "execute()", so there should be a "X" to denote end of lifeline beneath the activation bar of execute().

Noticed this issue in various other diagrams too.

nus-pe-bot commented 2 years ago

Team's Response

The add-applicant command will be referenced again when undo command is called.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

[x] I disagree

Reason for disagreement: Technically only "undo-able" commands (add-position, add-applicant, edit-position, edit-applicant, delete-position, delete-applicant , mark) will be referenced again, so things like FindCommand will not be, so I am only half correct I guess.