search

BenjaminLawson / PDF.js-Viewer-Shortcode

A Wordpress plugin for embedding PDFs using Mozilla's Excellent PDF.js
https://wordpress.org/plugins/pdfjs-viewer-shortcode/
GNU General Public License v3.0
6 stars 7 forks source link

Update PDFjs Library #2

Open TwisterMc opened 5 years ago

TwisterMc commented 5 years ago

The current PDFjs version is 2.0.943 and it appears this plugin is using 1.4.20. Any chance we'll see an update anytime soon?

BenjaminLawson commented 5 years ago

That would be a great thing to do, but I'm not sure I'll have time to do that in the near future as updating PDFjs in this plugin requires updating misc. lines in the PDFjs source code. Feel free to make a pull request!

BenjaminLawson commented 5 years ago

@TwisterMc I saw your fork, great work! Are you interested in taking over the plugin on wordpress.org and this repository?

TwisterMc commented 5 years ago

I'm not sure about taking everything over as I'm not sure how to do SVN anymore. I've never submitted a plugin to WordPress.org so I'm a bit hesitant. :)

If you think my code looks good, you can merge it back in. I did some testing, but not a ton. I'm getting a weird error in Firefox but I'm not sure if it's just me or what. Doesn't happen in private mode or Waterfox.

I actually made very few changes to your code. It was actually pretty easy to get things updated.

BenjaminLawson commented 5 years ago

I don't remember either, but wordpress.org has a nice guide: https://developer.wordpress.org/plugins/wordpress-org/how-to-use-subversion/ . I remember it being pretty simple.

The changes I was referring to are the PHP snippets in https://github.com/BenjaminLawson/PDF.js-Viewer-Shortcode/blob/master/pdfjs/web/viewer.php that enable the shortcode options.

Also, pdfjs has a few large files that shouldn't be included in the submitted plugin, like the demo PDF file and some large .map files (this plugin was actually rejected when I first submitted it for that reason...)

TwisterMc commented 5 years ago

I guess I could give this a go if you're too busy. :)

BenjaminLawson commented 5 years ago

Great! I added you as a committer on wordpress.org and sent you an invite to be a collaborator on this repo. Feel free to keep work on your fork and to change any readme/metadata you want!

TwisterMc commented 4 years ago

I've been trying to submit an updated plugin to WordPress.org and it doesn't accept my login. Not sure what I'm doing wrong but I'd like to get a new version out. Any ideas?

BenjaminLawson commented 4 years ago

I recommend either resetting your password (if you still have access to the email), or making a new account (and I'll add it to the plugin contributors).

BenjaminLawson commented 4 years ago

I recommend deleting pdfjs/web/compressed.tracemonkey-pldi-09.pdf

TwisterMc commented 4 years ago

Ok, I figured out how to commit to the plugin directory. 🎉

Next up is how to submit a new release. Coming soon. 😄