search

BenjaminMatembe / Portfolio

This project is to show case my built projects using the different technologies and skills acquired in the microverse curriculum. Built with HTML and CSS
1 stars 1 forks source link

Portfolio: Finish mobile version #3

Closed BenjaminMatembe closed 1 year ago

BenjaminMatembe commented 1 year ago

On this project Feature I:

BenjaminMatembe commented 1 year ago

@Kamba56 thank your for the review. However, apart from the commented blocks of code, kindly guide me well on what is stopping my pull request from passing.

Is it the low level of great use of github or the background colors of the hover and active state only? and is this supposed to apply on all the buttons?

Kamba56 commented 1 year ago

@Kamba56 apart from the commented blocks of code, kindly guide me well on what is stopping my pull request from passing.

Is it the low level of great use of github or the background colors of the hover and active state only? and is this supposed to apply on all the buttons?

Hello @BenjaminMatembe The commented code and the hover and active state is what is blocking your progress. The other suggestion is an optional suggestion, you can choose to implement it or not.

The hover and pressed state should be implemented for all your buttons, please and they should look like the figma template.