Add_hamberger_menu - Githubissues

BenjaminMatembe / Portfolio

This project is to show case my built projects using the different technologies and skills acquired in the microverse curriculum. Built with HTML and CSS

1 stars 1 forks source link

Add_hamberger_menu #9

Closed BenjaminMatembe closed 1 year ago

BenjaminMatembe commented 1 year ago

On this branch I:

Added hamberger menu that appears on click of the hamberger button and also added the functionality so that:-

When the user clicks (or taps) the hamburger button, the mobile menu appears.
When the user clicks (or taps) the close (X) button, the mobile menu disappears.
When the user clicks (or taps) any of the mobile menu options, the mobile menu disappears.
When the user clicks (or taps) any of the mobile menu options, a correct part of the page is displayed.

BenjaminMatembe commented 1 year ago

Hi @joskalenda , Thank you for the feedback about the requested changes. Kindly clarify on this for me, I thought we are working on the same portfolio project and the task now is to add javascript functionality. In this case am wondering why you advise me to remove the other sections of the project yet the links have to direct to those sections too when clicked.

Am open to the clarification please. Thank you.

medaminedev66 commented 1 year ago

Hello @BenjaminMatembe 👋,

This is an additional review as a result of the second opinion request.

We apologize for the mistake; the code reviewer, @joskalenda, reviewed the wrong project. Please request another review for your 'Mobile Menu' project on your dashboard, and the next reviewer will ensure that it meets the necessary requirements. Don't worry about exceeding your review limit; you can still request a Second Opinion if necessary.

Keep rocking 🚀!