search

BenjaminMedia / image_system

This is a image system, which will provide:
0 stars 1 forks source link

Features/cropping/generators #17

Closed andreorvalho closed 10 years ago

andreorvalho commented 10 years ago

Status: Ready to merge

Responsible: Andre Orvalho Reported: Andre Orvalho Relevant to: cropping images

This will make sure we have generators for cropping models This also refactors the helpers

andreorvalho commented 10 years ago

@jokklan @yiannisvh can somebody please code review this :)

jokklan commented 10 years ago

Looks fine :)

yiannisvh commented 10 years ago

@andre there's this binary file spec/dummy/dummy_imagesystem_test, what is it supposed to contain?

andreorvalho commented 10 years ago

About that binary file!

I am not sure yet, but I think it's created as the database for test(I am using sqlite3 its faster and easier to setup).

It gets changed every time I ran the tests! I have stop commiting it and I have tried to removing it but the tests failed in Travis so I just commited a version and dont commit anymore!

I am planing on investigate on it as soon as I have the time, if you want you can open an issue and I will look into it as soon as possible!

yiannisvh commented 10 years ago

@andreorvalho ok, well, it's not showstopper, but I just wanted to know what it was doing there :) for the rest this seems ready