Features/different image formats/image concern

BenjaminMedia / image_system

This is a image system, which will provide:

0 stars 1 forks source link

Features/different image formats/image concern #23

Closed andreorvalho closed 10 years ago

andreorvalho commented 10 years ago

Status: ready to merge

Responsible: Andre Orvalho Reported: Andre Orvalho Relevant to: different image types

This adds file_extension as a database field to be implemented by the concern. It adds tests that make sure file extension is used to communicate with cdn since it's necessary

andreorvalho commented 10 years ago

@jokklan can you please code-review this

jokklan commented 10 years ago

Seems good :)! However it's even another feature integrated by paperclip or carrierwave...

andreorvalho commented 10 years ago

Yes it is! And I have been looking at their code for this!

But like we talked before how would you integrate CDN with carrier wave? probably would be harder than building the solution we needed!

And besides this and cropping I can't see how carrierwave would help us!

andreorvalho commented 10 years ago

@jokklan please merge when you feel it's good!