Change default style-prefix from None to 'fa'

BenjjinF / django-fontawesome-5

A utility for using icons in models, forms, and templates.

BSD 2-Clause "Simplified" License

21 stars 18 forks source link

Change default style-prefix from None to 'fa' #7

Closed n-elie closed 4 years ago

n-elie commented 4 years ago

Hello,

Maybe I misunderstood something but I can't manage to make the syntax {% fa5_icon 'check' %} work. This produce this king of html output : <i class="None fa-check " ></i> If I specify the style_prefix like this: {% fa5_icon 'check' 'fa' %}, this works well: <i class="fa fa-check " ></i>

This pull-request replace the default None value of Icon.style_prefix to 'fa'

Regards

BenjjinF commented 4 years ago

I've got a couple more changes locally that I'm planning to merge in this weekend; I'll include this in along with them ~

BenjjinF commented 4 years ago

Upon review, it seems that this should have defaulted to 'fas' rather than 'fa'. I've made the appropriate changes.