search

Benjol / SE-AutoReviewComments

AutoReviewComments - Pro-forma comments for SE
http://stackapps.com/q/2116
98 stars 39 forks source link

Humongous arrows in latest build #100

Closed LordFarin closed 8 years ago

LordFarin commented 9 years ago

image

The latest build introduces these fantastic arrows which make the extension border line unusable. They are present whether or not the "show/hide desc" option is used.

Please fix this ASAP.

I'm using Comodo Dragon browser, which for practically all purposes can be considered equal to Google Chrome. I'm on Windows 7 x64, should it matter.

Benjol commented 9 years ago

Practically all purposes except this apparently :) Just out of curiosity, have you tried it in Chrome. Also, which site is this on? (Normally those arrows should only appear on hover)

Ben

-----Original Message----- From: "LordFarin" notifications@github.com Sent: ‎16/‎05/‎2015 20:51 To: "Benjol/SE-AutoReviewComments" SE-AutoReviewComments@noreply.github.com Subject: [SE-AutoReviewComments] Humongous arrows in latest build (#100)

The latest build introduces these fantastic arrows which make the extension border line unusable. They are present whether or not the "show/hide desc" option is used. Please fix this ASAP. I'm using Comodo Dragon browser, which for practically all purposes can be considered equal to Google Chrome. I'm on Windows 7 x64, should it matter. — Reply to this email directly or view it on GitHub.

LordFarin commented 9 years ago

It's the same in Chrome. I'm on Maths.SE (http://math.stackexchange.com/).

It might have to do with a recent complete overhaul of the UI, see http://meta.math.stackexchange.com/q/20047/43351.

Thanks for looking into it.

oliversalzburg commented 9 years ago

Yeah, it's caused by recent CSS updates of buttons. :\

Benjol commented 9 years ago

@LordFarin, there is a fix from Oliver, but no release to go with it at present. Do you have the wherewithall to build and check?

LordFarin commented 9 years ago

@Benjol Unfortunately, no. However, I do have some past experience with Git so with some quick pointers I should be able to manage.

oliversalzburg commented 9 years ago

@LordFarin https://github.com/Benjol/SE-AutoReviewComments/wiki/Building should get you started :)

LordFarin commented 9 years ago

@oliversalzburg I managed to do it. It now looks like this:

image image

That is much better, but there is still something strange going on with the arrow when the comment is still folded.

You can also see the translucent arrow of the top comment (just above "insert now" in the second picture), which also seems unintended.

oliversalzburg commented 9 years ago

@LordFarin Yeah, that's what I was seeing as well. I wanted to leave it there like that to give users a hint that there is something to interact with.

If you have any suggestions on how to improve it, I'm all ears :)

LordFarin commented 9 years ago

@oliversalzburg What I would do (if it's possible) is the following:

  1. Scale the arrow so that it fits the vertical space used by the folded/unfolded comment.
  2. Always show the arrow to the right on hover of the comment (instead of only when you hover all the way to the right).

This should fix the translucent arrow overflow and IMO it would also make the interface more intuitive. I hope it is clear what I envisage.

oliversalzburg commented 9 years ago

@LordFarin I implemented your second suggestion. Scaling the height of the arrow wouldn't be very easy.

I'll submit a new PR.

bjb568 commented 9 years ago

Removing these:

height:100%;margin:0;font-size:300%;color:transparent;background-color:transparent;border:0;transition:.3s;text-shadow:0 0 1px #fff;cursor:pointer

makes it usable. That's how I'm modding it indefinitely, or until pushing the update button doesn't move my cheese like that o_o

Screenshot

oliversalzburg commented 9 years ago

@bjb568 Humm, yeah, that doesn't look too bad either. Feels more in-tune with the overall UX. I might give it another do-over.

I've never heard the phrase "move my cheese" before btw. I like it :D

Benjol commented 9 years ago

Personally I prefer the translucent until hover, but I'll take whatever you PR.

@oliversalzburg: http://en.wikipedia.org/wiki/Who_Moved_My_Cheese%3F

You probably have seen it before, just not noticed (http://meta.stackexchange.com/search?q=cheese+moved)

oliversalzburg commented 9 years ago

@Benjol I would recommend merging #102 for now and pushing a release, as the current version is hardly usable.

Other changes would probably come later on.

And thanks for the cheese moving insights ;D