Default welcome message references incorrect variable for site name

[samliew]

Fresh install of AutoReviewComments userscript uses the wrong site name.

Welcome to Where Developers Learn, Share, & Build Careers!

[samliew]

I think this is due to the script using the window title, and the format has changed recently?

[samliew]

I recommend using the existing global variable for this instead

var sitename = StackExchange.options.site.name;

[oliversalzburg]

If you submit a pull request, I'd merge it, but I try not to contribute to Stack Overflow anymore in any way myself. Not sure about the other maintainers :)

[Benjol]

I'm still here, though not very involved either.

On Thu, 20 Sep 2018 at 12:02, Oliver Salzburg notifications@github.com wrote:

If you submit a pull request, I'd merge it, but I try not to contribute to Stack Overflow anymore in any way myself. Not sure about the other maintainers :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Benjol/SE-AutoReviewComments/issues/156#issuecomment-423122978, or mute the thread https://github.com/notifications/unsubscribe-auth/AARPAvYgUNCK64LIQwfH0hDFcIpbVkuaks5uc2evgaJpZM4WxMe7 .

[samliew]

@oliversalzburg how do I get the src built into dist? Is there CI set up or should I also make a manual PR for the dist version of the userscript?

[Benjol]

@samliew does this page in the wiki answer your question? https://github.com/Benjol/SE-AutoReviewComments/wiki/Building Or are you asking about getting that back here in the Releases in github?

[samliew]

Yes, the latter. Correcting the source isn't good enough as by itself isn't installable by the userscript manager.

[oliversalzburg]

@samliew I rebuilt the dist files and pushed them up. Is that sufficient?

[samliew]

Sweet! Thanks, that will do fine