search

Benjol / SE-AutoReviewComments

AutoReviewComments - Pro-forma comments for SE
http://stackapps.com/q/2116
98 stars 39 forks source link

Fix for Feb 20, 2019 Stack Overflow DOM update #164

Closed machavity closed 5 years ago

machavity commented 5 years ago

163

Benjol commented 5 years ago

Thanks, once I get on front of a PC I'll merge this and maybe even get as far as a release...

-----Original Message----- From: "Joel Hutchinson" notifications@github.com Sent: ‎20/‎02/‎2019 17:05 To: "Benjol/SE-AutoReviewComments" SE-AutoReviewComments@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Subject: [Benjol/SE-AutoReviewComments] Fix for Feb 20, 2019 Stack OverflowDOM update (#164)

163

You can view, comment on, or merge this pull request online at: https://github.com/Benjol/SE-AutoReviewComments/pull/164 Commit Summary Fix for Feb 20, 2019 Stack Overflow DOM update File Changes M dist/autoreviewcomments.user.js (2) Patch Links: https://github.com/Benjol/SE-AutoReviewComments/pull/164.patch https://github.com/Benjol/SE-AutoReviewComments/pull/164.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Benjol commented 5 years ago

Release later, sorry.

gparyani commented 5 years ago

@Benjol When will userscript users be able to see the change? Also, the version number hasn't been updated.

IzzySoft commented 5 years ago

Ah cool, then I don't need to add that. Just found the place that changed – but @machavity was faster. Thanks!

PS: As my co-mods will certainly ask the same, I chime in with @gparyani in the ETA question :smile:

Benjol commented 5 years ago

Version tomorrow Release depending on whether I can get git through firewall...

-----Original Message----- From: "Izzy" notifications@github.com Sent: ‎20/‎02/‎2019 20:24 To: "Benjol/SE-AutoReviewComments" SE-AutoReviewComments@noreply.github.com Cc: "Benjol" ben.simkins@gmail.com; "Mention" mention@noreply.github.com Subject: Re: [Benjol/SE-AutoReviewComments] Fix for Feb 20, 2019 StackOverflow DOM update (#164)

Ah cool, then I don't need to add that. Just found the place that changed – but @machavity was faster. Thanks! PS: As my co-mods will certainly ask the same, I chime in with @gparyani in the ETA question 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Benjol commented 5 years ago

Just for future reference, you need to update src\autoreviewcomments.user.js and not dist\autoreviewcomments.user.js. Then you run the build.sh script to generate everything in dist\ cf: https://github.com/Benjol/SE-AutoReviewComments/wiki/Building