search

BennMacdonald / AGM_RPackage

1 stars 0 forks source link

Explaining user defined ODE with deSolve #20

Open BennMacdonald opened 6 years ago

BennMacdonald commented 6 years ago

In our documentation, we describe how to specify user ODEs as R functions ("Specifying ODE systems as R functions"). When they use deSolve, we tell them to use a wrapper function, so that the function is compatible with scalar t. Hence, in the example we give, test.data uses deSolve_LV_func instead of LV_func, so that the reader understands.

My question is this: When we get to the section "Parameter inference by explicitly solving the ODE system", should we not also use deSolve_LV_func instead of LV_func, since we use deSolve to solve the ODEs? I know it will still work given how we use LV_func, but should we not use deSolve_LV_func to help the reader understand how to do it for examples they will be working on?

If you think so, I can update it whilst updating the Roxygen information for doMCMC.

BennMacdonald commented 6 years ago

I have included this change in the push to git. I can revert it back if you object to the change.