search

BennMacdonald / AGM_RPackage

1 stars 0 forks source link

Parameter initialization can be over-written by keepInit option #6

Open FrankD opened 7 years ago

FrankD commented 7 years ago

The parameters can be initialized by the paramsInit vector, but if keepInit=FALSE, they get re-initialized at random for each chain. Fix would be to only initialize at random if paramsInit=NULL. Easy fix, I'll implement when I have time.

BennMacdonald commented 7 years ago

There does not seem to be a way for users to implement keepInit=FALSE, since it is not an argument in agm(). We could include the argument and put the fix in, or leave it out altogether. What do you prefer? I can update the files if we want to include keepInit=FALSE, if you like.

Currently, since keepInit is not an argument of agm(), if users do not specify initial parameter values, the function takes a draw from the prior(s). If the users do give initial parameter values, then they should not be overwritten, as the current code has keepInit=TRUE (and the users cannot edit this).

If there is some use for users to change keepInit to FALSE, then we should change the code to remove the bug. I cannot think of why it would be useful to them though, is there something I am missing?