Benni-chan / nzbToAniDB

postprocessing script for animes (to use with sabnzbd+ or nzbget or even as stand alone) to rename files after a sync with anidb.net. files can additionally be renamed via tvdb
24 stars 7 forks source link

Renamer may add trailing dot [.] at end of foldername #29

Open avluis opened 9 years ago

avluis commented 9 years ago

I was tracking this down on my Windows computers (OS X automatically removes trailing dots from folder names and Linux does not have this restriction) due to some folders receiving Windows truncated folder (file) naming. Turns out that the script can add a trailing dot to the folder names causing Windows clients to truncate the folder name into something 'accessible' to Windows Explorer.

An example of this behavior can be reproduced when renaming series that have a trailing dot like: Ore, Twintail ni Narimasu. Kobato.

This issue is particular to the way Windows handles extensions (I have no idea why Windows thinks folders can be files!), so if the dot is the last thing in a folder/file, it will be expecting an extension. The truncating happens when a folder already exists (Windows will remove the trailing dot from the folder name automatically if created in Windows). From my observations, Windows has no issue handling the dot anywhere else in the folder name, it just cannot be at the end.

This may be of some help to narrow down what would be considered safe when it comes to the different OS combinations out there.

Benni-chan commented 9 years ago

thanks, i'll put a fix in the next version.