search

Bennik2000 / DHBWStudentInformationApp

The DHBW student app offers you the opportunity to view your schedule on your smartphone. You can also view the grades from Dualis directly in the app.
GNU Affero General Public License v3.0
48 stars 9 forks source link

Fix Dualis login #135

Closed MaarxS closed 1 year ago

MaarxS commented 1 year ago

Fixes the Dualis Login. The position of the link is no longer inside the meta tags. I've changed the approach so that the readRedirectUrl function returns the First link which contains the substring "Startseite".

fixes #134

Bennik2000 commented 1 year ago

Hey, thank you for this fix.

Did you test your changes? When I try to build the app it does not compile because you deleted the getUrlFromHeader function. Can you try to fix this and confirm that the dualis authentication works again?

Bennik2000 commented 1 year ago

@MaarxS can you please confirm that it works from your side?

MaarxS commented 1 year ago

I fixed it by readding the getUrlFromHeader function. I didn't notice that the function was stilled used.

I've tested it and the app and the dualis login works on the android emulator and on my android phone. The Unit tests also passed (apart from one that already failed before my changes).

mwoelke commented 1 year ago

I can confirm that dualis is working for me again after applying the readRedirectUrl() function from this pull request.

Thank you very much @MaarxS ! I've been looking into this as well the past days but you've been faster :)

tuke307 commented 1 year ago

Why is only the Android Version getting Updated? #136