BennoGAP / notification-forwarder-v3

GNU General Public License v3.0
1 stars 4 forks source link

feature request: option to let apps which support it use replies #1

Closed tabascoeye closed 1 year ago

tabascoeye commented 1 year ago

I found there is an app which has the same use-case but has working replies. The huge con for that is that the apps it supports is hardcoded and limited to just a few (WhatsApp, Telegram,...). (https://play.google.com/store/apps/details?id=com.integrationsfortesla.messaging&hl=en&gl=US)

From what I understand/suspect, the app does the following different from notification-forwarder-v3:

For the "use the notification to direct-reply" thing there are a few links: https://mobikul.com/direct-reply-from-notification/ https://medium.com/software-engineers-toolbox/direct-reply-notification-for-android-in-4-steps-5612b49b5487 https://stackoverflow.com/questions/59251922/how-to-send-a-reply-from-a-notification

But for the "listen to incoming SMS and react on them" it's hard to find something solid. I have seen the "outbox": http://docs.52im.net/extend/docs/api/android-50/reference/android/provider/Telephony.Sms.Outbox.html

So it would be amazing if we could:

BennoGAP commented 1 year ago

Hi, thanks for your suggestion.

From my understanding the app does the following:

While this itself is managable to implement, there are a few problems:

I will consider this as an additonal option in the future - but not with a very high priority

johan12345 commented 1 year ago

Hi, I would also be interested in this feature and could help with testing or possibly even try to contribute.

BUT (from my understanding) the sms message is still send out to the phone provider - the phone provider answer with "sending failed" because he doesnt know a phonenumber "316". This is working on the technial side - but i dont like the idea, that the message is send to the phone provider anyway.

Hm yeah, simply taking "316" and assuming this number will fail might not be ideal. Maybe we should instead try a very long number (> 15 digits should be pretty unlikely to be a valid number...)? Though I guess that might still be sent to the provider instead of failing locally, right?

This seems to work fine on a Tesla - however a lot of cars fetch the phonebook at the beginning of the Bluetooth connection - so the "create a temporary contact to show 'John - WhatsApp'" does not work here.

In this case the reply function would still work, the name of the contact would just not be shown in the car - right? So yeah, this should definitely be an optional feature with a thorough description how it works and why it might break the display of contact names in some cars.