search

Benny- / Yahoo-ticker-symbol-downloader

A web scraper for ticker symbols from yahoo finance
https://pypi.python.org/pypi/Yahoo-ticker-downloader/
Other
247 stars 87 forks source link

No need for explicit encode #22

Closed algonell closed 7 years ago

algonell commented 7 years ago

Running for stocks, the line was having: UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1197: ordinal not in range(128)

Benny- commented 7 years ago

This is related to issue #16

It needs the encode in python3 but in python2 it does not. Omiting or including it will result in a error in one of the two versions.

This is because the tablib library always returns strings. And in python3 a string has a different meaning.

Work is being done to ensure it will work in both versions by returning a Unicode like object in both versions.

In the meanwhile I can accept pull request to make it work in both versions using the conditional in compact.py. I can not accept the pull request as it is now because this will only migrate the problem to python3 users.

Add this condition and it will be merged.

algonell commented 7 years ago

Got you