search

Benny- / Yahoo-ticker-symbol-downloader

A web scraper for ticker symbols from yahoo finance
https://pypi.python.org/pypi/Yahoo-ticker-downloader/
Other
247 stars 87 forks source link

Fix for Python >= 3.5 #25

Closed kamgha closed 7 years ago

kamgha commented 7 years ago

I'm using Python 3.5 and 3.6 and the latest "tablib" (0.11.4). This fix checks for Python >= 3.5 (this might be wrong!), however I've not tested this with Python < 3.5, the problem will be from Python >= 3.5 or the current tablib version. The source of this problem has to be determined.

Benny- commented 7 years ago

What does this fix?

kamgha commented 7 years ago

This is probably related to https://github.com/Benny-/Yahoo-ticker-symbol-downloader/pull/24

It fixes this error when saving the symbols to CSV:

Exporting Stock symbols Traceback (most recent call last): File "YahooTickerDownloader.py", line 152, in main() File "YahooTickerDownloader.py", line 138, in main f.write(data.csv.decode('UTF-8')) AttributeError: 'str' object has no attribute 'decode'

Benny- commented 7 years ago

I have added a comment to pull request #24. This pull request will be closed and a proper fix will be made at a later time. Thank you for being a master tester :+1: .