Benny- / Yahoo-ticker-symbol-downloader

A web scraper for ticker symbols from yahoo finance
https://pypi.python.org/pypi/Yahoo-ticker-downloader/
Other
247 stars 87 forks source link

a little suggestion #31

Closed istzustand closed 7 years ago

istzustand commented 7 years ago

Hi. I'm new to this git and programming stuff, so please bear with me :)

if I query stocks I'm getting 22049 symbols from 9 exchanges. Since I'd love to have more I fiddled a bit around and got your tool to get 28094 symbols from 66 exchanges.

All I had to do was in the ytd/SymbolDownloader.py add " 'm' : 'all' " to params.

This now enables me to filter for stocks which are traded e.g. in Frankfurt which I find awesome ;)

dunno if you want to drop that line but I thought I'd share my idea (:

edith says: I'll try this branching and pull request stuff... let"s see... edit2: I made a mistake. I was formerly pulling from de.finance.yahoo. Now back at finance.yahoo I get 105539 stocks from 69 exchanges. Still about 9k missing.

Benny- commented 7 years ago

Thank you! I'll merge it right away when I get home.

And welcome to github

Sent using the GMX mail app

On 10/05/2017 at 01:41, istzustand wrote:

Hi. I'm new to this git and programming stuff, so please bear with me :)

if I query stocks I'm getting 22049 symbols from 9 exchanges. Since I'd love to have more I fiddled a bit around and got your tool to get 28094 symbols from 66 exchanges.

All I had to do was in the ytd/SymbolDownloader.py add " 'm' : 'all' " to params.

This now enables me to filter for stocks which are traded e.g. in Frankfurt which I find awesome ;)

dunno if you want to drop that line but I thought I'd share my idea (:

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/Benny-/Yahoo-ticker-symbol-downloader/issues/31