BennyE / stellar-add-guest

stellar-add-guest is a small tool to generate a new guest for Stellar Wireless (Enterprise mode) in OmniVista 2500 hosted on OmniSwitch with AOS Release 8
MIT License
3 stars 0 forks source link

Feature Request - Add QRCODE #1

Open ebcoelho opened 2 years ago

ebcoelho commented 2 years ago

Hi Benny, can you add a QRCODE like on https://github.com/BennyE/stellar-dynpsk with option for WPA/WPA2-PSK or NOPASS for Open SSID's.

I found this code from https://github.com/lakhanmankani/wifi_qrcode_generator showing how to generate a QRCODE for an Open SSID. if authentication_type in ('WPA', 'WEP'): if password is None: raise TypeError('For WPA and WEP, password should not be None.') return 'WIFI:T:{type};S:{ssid};P:{password};H:{hidden};;'.format( type=authentication_type, ssid=ssid, password=password, hidden=hidden ) elif authentication_type == 'nopass': if password is not None: raise TypeError('For nopass, password should be None.') return 'WIFI:T:nopass;S:{ssid};H:{hidden};;'.format( ssid=ssid, hidden=hidden ) raise ValueError('Unknown authentication_type: {!r}'.format(authentication_type))

Thanks for your Github Projects that we use for PoC and ALE Presales Presentations and for your awesome wiki at http://dokuwiki.alu4u.com

BennyE commented 2 years ago

Hi,

Do you mean to have a captive portal on a either an open or WPA2-protected SSID? This script creates a guest user in the Captive Portal (UPAM). I need to find out if the necessary library (qr / png) can run on the OmniSwitch, otherwise it would have to be a separate branch.

Thanks, Regards, Benny

ebcoelho commented 2 years ago

Hi Benny,

Usually the iOS devices don't trust on Open SSID's used for Guest users, when the iPhone sleeps and wakes up on my experience they don't reconnect every time. As workaround I usually manage Guest SSID's with WPA2-PSK (AES) and Captive Portal because usually old phones don't support WPA3 (old hardware or operational system old releases). So the idea is to use your implementation for create a guest account and attach the QRCODE to simplify the on boarding of guest users :)

Regards, Eduardo

BennyE commented 2 years ago

Hi Eduardo,

I like the idea, thanks for the clarification. We can only store the PSK (or details about the open SSID) in the QR code. The user will still have to onboard themselves via the Captive Portal with the Guest Account after scanning the QR code.

I'm still travelling for business this week and will be on vacation afterwards. I'm not sure when I can get to this topic.

Thanks, Regards, Benny

ebcoelho commented 2 years ago

Hi Benny,

Take your time and enjoy your vacation time. In mean time I'll will use both scripts to show the concepts of creating a guest user using OmniSwitch and the possibility to generated a QR code with the https://github.com/BennyE/stellar-dynpsk, thanks!

Regards, Eduardo Coelho

BennyE commented 1 year ago

Hi @ebcoelho,

Please review/try https://github.com/BennyE/stellar-add-guest/tree/qrcode and let me know.

Benny