Improve clarity, particularly in Obelisk.Document

BennyHallett / obelisk

Static Site Generator written in Elixir.

MIT License

393 stars 34 forks source link

Improve clarity, particularly in Obelisk.Document #33

Closed jonnystorm closed 8 years ago

jonnystorm commented 8 years ago

Broke compile/2 and prepare/2 into smaller pieces, emphasizing common patterns
Expanded Obelisk.Renderer.render API to accept combined layout tuple
Expanded Obelisk.Renderer.render API to handle Earmark call
Added tests for expanded Obelisk.Renderer.render API
Changed highly nested calls in title/1 to pipes
Made minor refactorings to prevent warnings in later Elixir versions

trans commented 8 years ago

Hmmm.... six months old. Is this project alive?

jonnystorm commented 8 years ago

@trans There are plenty of recent commits, but this pull request may not necessarily fit the maintainer's criteria.

While it doesn't necessarily change any logic, the changes involve several files, with what could be considered niggling changes in code style, and the whole thing may just be too large.

I had actually forgotten all about this, and for reasons above, I'm closing this.