search

BennyHallett / obelisk

Static Site Generator written in Elixir.
MIT License
393 stars 34 forks source link

Update dependencies #46

Open ghost opened 7 years ago

ghost commented 7 years ago

Obelisk wasn't compiling because it was referencing the latest yamerl master branch on GitHub. I pinned yamerl to the version used by yaml_elixir and then updated all the other dependencies while I was at it.

vjousse commented 7 years ago

Hi there,

I just checked this PR locally, and this should not be merged as it is: it's breaking the CLI commands because of the anubis upgrade.

Parameters to the run function coming from anubis are now of the form {arguments, options, runtime_configuration} instead of only arguments.

Tests are passing because they are not testing the anubis part, only the run part of the obelisk task.

I've provided a quick fix here: https://github.com/vjousse/obelisk/commit/ec75ce1a8e64955871d278e6f587937e986be7d9

I would be interested in a way of testing the anubis part as it would avoid future problems with commands. Unfortunately, there is no example test in anubis and I don't really know where/how to start.

BennyHallett commented 7 years ago

Sorry for being so slack with Obelisk @uranther - Thanks for your contribution. I'll have to look a bit longer at upgrades, as per @vjousse comment. I also think I'll jump all the way to Elixir v1.4.0 to bring Obelisk back up to date, so that may squash some of these changes.

I'll keep you updated either way.

Thanks again for contributing.

ghost commented 7 years ago

Thanks @vjousse and @BennyHallett! Yes, some automated tests for Anubis commands will be needed. I'll try to pull this up and work on it this week.