BennyKJohnson / OpenCloudKit

Open Source CloudKit Framework
MIT License
96 stars 17 forks source link

CKURLRequest could be an operation subclass #13

Closed malhal closed 7 years ago

malhal commented 7 years ago

It is quite normal to wrap an NSURLSession task in an operation, and would fit here since it is already attempting to implement its own cancelled and finished. I could handle this.

BennyKJohnson commented 7 years ago

CKWebRequest was the old class that performed the URLRequests on behalf of the task. It's now been replaced with CKURLRequest however some of the operations still use CKWebRequest. CKURLRequest still needs some work though, if you would like to work on that.

malhal commented 7 years ago

Sorry yeh I meant CKURLRequest

BennyKJohnson commented 7 years ago

I'm not in favour for this without a really good reason for doing so. It doesn't match the CloudKit Daemon implementation found here