BennyKok / comfyui-deploy

An open source `vercel` like deployment platform for Comfy UI
https://comfydeploy.ing
GNU Affero General Public License v3.0
982 stars 126 forks source link

Modal Integration #1

Closed slavakurilyak closed 8 months ago

slavakurilyak commented 9 months ago

As per README, it is "possible to set up a clean environment via Salad, Modal, etc."

Modal is perfectly suited to deploy comfyui-deploy, pun intended, as it can "scale to infinity, and to zero." In other words, Modal can handle deployment and scaling of ComfyUI by @comfyanonymous.

Check out their image, video, and 3D use cases here.

Modal became generally available on Oct 10, or 74 days ago.

For coding inspiration, check out a1111_webui.py by @modal-labs or running Stable Diffusion WebUI using Modal by 14nigo.net.

BennyKok commented 9 months ago

Will definitely start looking into this in the following weeks. Meanwhile if anyone wanted to help out would be really appreciated.!

Ehesh commented 9 months ago

Looks nice but the modal storage... $2 per GB/mo...

BennyKok commented 9 months ago

Looks nice but the modal storage... $2 per GB/mo...

Im curious where can I find this in the pricing plan page? I couldn't find the information about storage cost on modal

aksh-at commented 9 months ago

We also have an example for running comfy UI directly over websockets :)

BennyKok commented 9 months ago

@aksh-at Yes! Already intergrated! YOU guys have been awesome in the slack group! shout out to Jonathon for the great example. Also looking to integrate more with modal, like optimizing for cold start and stuff, would love to have a technical deep dive with you guys afterward, to clear up my understanding with modal's infra and how can I better optimize for the current implementation.

xllusion-dong commented 7 months ago

How to support API in modal?