BennyKok / comfyui-deploy

An open source `vercel` like deployment platform for Comfy UI
https://comfydeploy.ing
GNU Affero General Public License v3.0
1.03k stars 135 forks source link

fix(media upload): skip when using the CD_BYPASS_UPLOAD env var #51

Closed EmmanuelMr18 closed 4 months ago

EmmanuelMr18 commented 4 months ago

fix(upload outputs): skip images/gifs/files/mesh when env var is true

The env var is CD_BYPASS_UPLOAD. When that variable is True, we shouldn't upload the media to our comfy deploy s3 bucket.

There are 2 steps.

  1. save the file into our s3 bucket
  2. save the output details into our database.

When CD_BYPASS_UPLOAD is True:

  1. Skip the save file into our s3 bucket
  2. Skip the save into our database.

Previously, we were skipping the step 1, but not the step 2. So that is the reason of why we keep seeing the comfy deploy URL when fetching the run details:

outputs: [
  {
    data:{
      gifs: [
        {
          url: "https://comfy-deploy-output.s3.amazonaws.com/video.mp4"
        }
      ],
      text: [
        "A text that you displayed with show text node"
      ]
    }
  }
]

With the new changes we don't save that into our database, and fetching the details of a run will look like this:

outputs: [
  {
    data:{
      text: [
        "A text that you displayed with show text node"
      ]
    }
  }
]