search

BennyThadikaran / eod2

A fully automated script to download and update NSE EOD Historical stock, index and delivery data with added features
GNU General Public License v3.0
68 stars 24 forks source link

splits was not adjusted on old data #165

Closed tradewithmadhan closed 2 months ago

tradewithmadhan commented 3 months ago

HI BennyThadikaran, when i check old data come to know that stock splits was not adjusted ... Please check and fix if possible .. Ex. TCS
Jul 28, 2006 | 1/2 Stock Split Jun 16, 2009 | 1/2 Stock Split May 31, 2018 | 1/2 Stock Split

image

BennyThadikaran commented 3 months ago

Hi, I'm aware of this issue. The scripts written to compile EOD2 data were written some years back. EOD2 itself received many bug fixes but those fixes were not added to these scripts.

I completed updating the EOD2 compile scripts recently. Currently I'm working on moving the Corporate actions data from JSON files into Sqlite Db. This will make it faster to look up Ex Bonus / Split dates and verify if the adjustment was actioned successfully. It will also help in ongoing verification.

This might take another 2 weeks but will ensure the problem is fixed permanently. You can keep this issue open and will notify you once done.

tradewithmadhan commented 3 months ago

Hi Benny, Thanks for the update ...

BennyThadikaran commented 2 months ago

@tradewithmadhan

I have moved the corporate actions data into a DB and completed compiling the EOD2 data. I added some verification code to make sure all adjustments were made correctly. The dates you mentioned for TCS were also adjusted by the script.

I also managed to fix some bugs with the split / bonus which were not detected earlier. I need to update the fixes in EOD2 and merge this new data in eod2_data repo.

If no further issues come up, I will update both repos on Saturday. Thanks for reporting this issue. Always helps :smiley:

BennyThadikaran commented 2 months ago

Its all done. You can follow the update instructions here to get the latest update. Make sure to update both eod2 and eod2_data repo.

BennyThadikaran commented 2 months ago

I am closing this issue for now. Let me know if there is any help you need.

tradewithmadhan commented 2 months ago

Thanks BennyThadikaran, you can close it