EOL tests fail on Windows - Githubissues

BenoitZugmeyer / eslint-plugin-html

An ESLint plugin to extract and lint scripts from HTML files.

ISC License

436 stars 51 forks source link

EOL tests fail on Windows #147

Closed jayvdb closed 2 years ago

jayvdb commented 3 years ago

Description

The following tests fail due to different EOL on Windows

should fix errors
should fix errors in files with BOM
eol-last rule › should work with eol-last always
eol-last rule › should work with eol-last never

Also should remap fix ranges fails, which may be EOL related, or could be something else

     expect(received).toEqual(expected) // deep equality

    - Expected  - 2
    + Received  + 2

      Array [
    -   53,
    -   55,
    +   56,
    +   58,
      ]

      465 |     })
      466 |
    > 467 |     expect(messages[0].fix.range).toEqual([53, 55])

Setup configuration

ESLint version: latest
eslint-plugin-html version: master
NodeJS version: v14
Operating System name and version: Windows

BenoitZugmeyer commented 2 years ago

Thanks to @nschonni, we fixed the tests on Windows and added Windows support in the CI (PR #158). Thanks for reporting this!