BenoitZugmeyer / eslint-plugin-html

An ESLint plugin to extract and lint scripts from HTML files.
ISC License
436 stars 51 forks source link

ci: Add OS to build matrix #152

Closed nschonni closed 2 years ago

nschonni commented 2 years ago

Related to https://github.com/BenoitZugmeyer/eslint-plugin-html/issues/147

nschonni commented 2 years ago

Noticed that @next actually points to an old RC for ESLint 8, so when explicitly for the versions

BenoitZugmeyer commented 2 years ago

Noticed that @next actually points to an old RC for ESLint 8, so when explicitly for the versions

@next will be used for each upcoming major releases (ex: ESLint 9 beta). I run the CI periodcally to be warned of potential breaking changes in future releases. I'd like to keep it this way.

I don't think we should extend the build matrix that much, especially for unit tests. We could run integration tests on Windows though, I think it makes more sense. Let me see how it could look.

BenoitZugmeyer commented 2 years ago

Thank you for your work on this! I adjusted your patch to my tastes, but you really helped me out here. Greatly appreciated!