fix problem with Atom - Githubissues

BenoitZugmeyer / eslint-plugin-html

An ESLint plugin to extract and lint scripts from HTML files.

ISC License

430 stars 51 forks source link

fix problem with Atom #24

Closed phaux closed 8 years ago

phaux commented 8 years ago

This fixed a crash which occurs when eslint is run via linter-eslint Atom plugin

BenoitZugmeyer commented 8 years ago

Thank you for your patch, but I don't think this is the right way to solve the issue because currentInfos should never be read before being defined.

I tried to reproduce the crash, but I can't. I tried:

atom 1.7.3 and 1.8.0
eslint 2.12.0 and 3.0.0
eslint-plugin-html 1.5.1
linter 1.11.14 + linter-eslint 7.2.4

Could you provide more informations about this: versions of software you are using, error message, maybe code samples?

phaux commented 8 years ago

Uhhh... I can't reproduce it anymore after I updated a few things. ¯_(ツ)_/¯

BenoitZugmeyer commented 8 years ago

Ok. Please reopen if you reproduce.