search

BenoitZugmeyer / eslint-plugin-html

An ESLint plugin to extract and lint scripts from HTML files.
ISC License
430 stars 51 forks source link

Avoid all lint errors on non-script linefeeds via eslint-disable-line #37

Closed platinumazure closed 7 years ago

platinumazure commented 7 years ago

While trying to consume this plugin in the QUnit repository, I discovered a bug with the //eslint-disable-line comments emitted by the extractor. Basically, they can also be subjected to the "lines-around-comment" rule in addition to "comment-spacing". Since the goal of those lines is merely to preserve location info between script tags and no actual code is contained within, I decided to generalize the comment so that all rules were disabled.

I've also added a test case which fails without the source change. Please let me know if you need anything else.

platinumazure commented 7 years ago

And if this is acceptable to merge, I'd love to see a patch release if it's not too much trouble :smile:

BenoitZugmeyer commented 7 years ago

That's great, thank you.

platinumazure commented 7 years ago

Thank you! I would love to see a patch release for this soon, please let me know if there's anything I can do to help make that happen.

BenoitZugmeyer commented 7 years ago

That's released!

platinumazure commented 7 years ago

Thank you very much!