search

BenoitZugmeyer / eslint-plugin-html

An ESLint plugin to extract and lint scripts from HTML files.
ISC License
430 stars 51 forks source link

Incompatability with eslint-plugin-eslint-comments #70

Closed jscharett closed 7 years ago

jscharett commented 7 years ago

The eslint-plugin-eslint-comments plugin seems to have 2 rules that require the column of the reported failure to be -1. This causes errors in this plugin as the TransformableString.locationToIndex checks for a 'valid' column of >= 0. I raised the issue with that project, but it was deemed necessary to have a value of -1. Is it possible to relax the rule here to allow for a negative value for column?

https://github.com/mysticatea/eslint-plugin-eslint-comments/issues/1

BenoitZugmeyer commented 7 years ago

Sorry for the reply delay. This is a smart hack from the eslint-comments plugin! I have a better fix idea: eslint is ignoring the messages before the html plugin is kicking in to remap messages, so we don't need to have invalid column numbers at this time. Let's just replace the column number with 1 in this case.