Benoss / django-elasticsearch-debug-toolbar

A Django Debug Toolbar panel for Elasticsearch
https://pypi.python.org/pypi/django-elasticsearch-debug-toolbar/
MIT License
29 stars 19 forks source link

Support Django debug toolbar 3.0 #14

Closed noamkush closed 2 years ago

noamkush commented 4 years ago

This fixes compatibility with DDT 3.0:

ghassanmas commented 3 years ago

@dimastbk, is there anything still blocking this PR, Let me know if there is anything I can do to speed up the process.

Benoss commented 3 years ago

I haven't worked on this for a very long time, but I will try to look at this over the weekend and if I can upgrade the repo to use Github Actions instead of Travis and release a version 3

barseghyanartur commented 2 years ago

For me the buttons (Show Json Body and Show Json Response) don't work.

settings/dev.py

DEBUG_TOOLBAR_PANELS = (
    # Defaults
    # 'debug_toolbar.panels.versions.VersionsPanel',
    "debug_toolbar.panels.timer.TimerPanel",
    "debug_toolbar.panels.settings.SettingsPanel",
    "debug_toolbar.panels.headers.HeadersPanel",
    "debug_toolbar.panels.request.RequestPanel",
    "debug_toolbar.panels.sql.SQLPanel",
    # 'debug_toolbar.panels.staticfiles.StaticFilesPanel',
    # 'debug_toolbar.panels.templates.TemplatesPanel',
    "debug_toolbar.panels.cache.CachePanel",
    "debug_toolbar.panels.signals.SignalsPanel",
    "debug_toolbar.panels.logging.LoggingPanel",
    "debug_toolbar.panels.redirects.RedirectsPanel",
    # Additional
    "elastic_panel.panel.ElasticDebugPanel",
)

INSTALLED_APPS += [
    "debug_toolbar",
    "elastic_panel",
]

Do they work for you?

noamkush commented 2 years ago

If you install my version (this PR) they will work. Try the following:

pip install https://github.com/noamkush/django-elasticsearch-debug-toolbar/archive/refs/heads/ddt3_fixes.zip
barseghyanartur commented 2 years ago

Great, thanks! Hey, as a proposal (what I would do in such cases) why don't you re-brand your branch as django-elasticsearch-debug-toolbar-reloaded and make a separate PyPI release, maintain the project, etc? And if one day this one would resurrect, the PR is there. :)

noamkush commented 2 years ago

Mostly for a lack of time. Maybe I'll do it next week

barseghyanartur commented 2 years ago

OK, if you still have doubts, I can do it based on your branch, make a PyPI release, etc. And add you as a maintainer on both PyPI and GitHub.

noamkush commented 2 years ago

@barseghyanartur Sure, I certainly don't have the spare time to take care of it at the moment.

barseghyanartur commented 2 years ago

@Benoss:

Wow! Thanks for merging. Could you make a PyPI release from the current master?

Benoss commented 2 years ago

Yes I am quickly switching to github actions as Travis.org does not work anymore, adding a few cleanup things like flake8 and black and then trying to release a version 3.0.0