Closed noamkush closed 2 years ago
@dimastbk, is there anything still blocking this PR, Let me know if there is anything I can do to speed up the process.
I haven't worked on this for a very long time, but I will try to look at this over the weekend and if I can upgrade the repo to use Github Actions instead of Travis and release a version 3
For me the buttons (Show Json Body
and Show Json Response
) don't work.
settings/dev.py
DEBUG_TOOLBAR_PANELS = (
# Defaults
# 'debug_toolbar.panels.versions.VersionsPanel',
"debug_toolbar.panels.timer.TimerPanel",
"debug_toolbar.panels.settings.SettingsPanel",
"debug_toolbar.panels.headers.HeadersPanel",
"debug_toolbar.panels.request.RequestPanel",
"debug_toolbar.panels.sql.SQLPanel",
# 'debug_toolbar.panels.staticfiles.StaticFilesPanel',
# 'debug_toolbar.panels.templates.TemplatesPanel',
"debug_toolbar.panels.cache.CachePanel",
"debug_toolbar.panels.signals.SignalsPanel",
"debug_toolbar.panels.logging.LoggingPanel",
"debug_toolbar.panels.redirects.RedirectsPanel",
# Additional
"elastic_panel.panel.ElasticDebugPanel",
)
INSTALLED_APPS += [
"debug_toolbar",
"elastic_panel",
]
Do they work for you?
If you install my version (this PR) they will work. Try the following:
pip install https://github.com/noamkush/django-elasticsearch-debug-toolbar/archive/refs/heads/ddt3_fixes.zip
Great, thanks!
Hey, as a proposal (what I would do in such cases) why don't you re-brand your branch as django-elasticsearch-debug-toolbar-reloaded
and make a separate PyPI release, maintain the project, etc? And if one day this one would resurrect, the PR is there. :)
Mostly for a lack of time. Maybe I'll do it next week
OK, if you still have doubts, I can do it based on your branch, make a PyPI release, etc. And add you as a maintainer on both PyPI and GitHub.
@barseghyanartur Sure, I certainly don't have the spare time to take care of it at the moment.
@Benoss:
Wow! Thanks for merging. Could you make a PyPI release from the current master?
Yes I am quickly switching to github actions as Travis.org does not work anymore, adding a few cleanup things like flake8 and black and then trying to release a version 3.0.0
This fixes compatibility with DDT 3.0:
ElasticDebugPanel.scripts