Benson15912 / pe

0 stars 0 forks source link

Confusing delete success message. #3

Open Benson15912 opened 2 months ago

Benson15912 commented 2 months ago

[Delete Message wrong]

Description

When deleting a patient, it shows that:

image.png

Does this id mean index or id field of the patient?

Expected

When deleting patient , id field should be shown instead of index.

Actual

However, index is shown instead

Steps to Reproduce

  1. add id/ 54321 n/ John Doe p/ John f/ Curry chicken c/ Stable h/ Singing karaoke t/ amnesia (add id of 54321)

image.png

  1. delete john doe

image.png

nus-se-bot commented 2 months ago

Team's Response

Hi! Thanks for pointing this out! I want to correct that this is not a functionality bug. This is the expected behaviour of the delete feature. The user guide have stated that the index refers to the index of the displayed patient list. The success message is created in a way that it follows the index that the user choose on the displayed patient list which is more consistent. However, after looking at the issue you are facing, we may consider to make the success message more intuitive in the future iteration:)

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The delete message is wrong, because ID and index have 2 different meanings in this product, the success message is giving the wrong description-number pair. Either it should have said "Patient John Doe with ID 54321 has been successfully deleted" or "Patient John Doe with index 7 has been successfully deleted", and not the success message that was shown in my initial bug report.

Hence this bug is valid.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** Should be functionality bug as i'm not shown the expected output. Expected: Patient John Doe with ID 54321 has been successfully deleted Actual: Patient John Doe with ID 7 has been successfully deleted