search

Bentheburrito / sacastats

A stat site for Connery's SaCa outfit members. Built with Elixir and Phoenix
MIT License
2 stars 0 forks source link

Fix set next aurax visibilities #131

Closed dm0896665 closed 2 years ago

dm0896665 commented 2 years ago

I actually had to change up the solution for this one. I originally thought that it needed to have the weapon status updated, but those are all of the stats, so pagination doesn't matter. So looking further into it I saw that the pagination on click events were not working after a filtration, which is now fixed.

To recreate show the next aurax weapon and use filtration to make it disappear and reapear. Notice the next aurax button should be working properly even after going back and forth between pages.

This will close #128

Bentheburrito commented 2 years ago

I noticed that adding a filter (e.g. Vehicle Weapons only) will cause the Go to Next Aurax button to disappear - is this the intended behavior? I'm listing 50 items per page, and there are many un-auraxed vehicle weapons visible image

dm0896665 commented 2 years ago

I noticed that adding a filter (e.g. Vehicle Weapons only) will cause the Go to Next Aurax button to disappear - is this the intended behavior? I'm listing 50 items per page, and there are many un-auraxed vehicle weapons visible

So yes, the original design of the next aurax button was to tell the user what they were closest to auraxing (i.e. the weapon with the highest kills below 1160) no matter what. If the data didn't show that weapon then it would be hidden. That being said, I like the way you are talking about making it based on the filter if the user would like to see "What's my next vehicle weapon to aurax". Do you want me to create a new issue for that, or just add it to this one since it's small and still part of the issue?

Bentheburrito commented 2 years ago

I think a new issue would be good since this behavior is what you intended. Thanks for the explanation!