Magic Leaves decay

[Chew]

Description

Describe the bug

Once a leaves block generates from a magic block, it can decay, leaving a hole as well as a hard time to find it. (Really a problem if it decays before you place any blocks)

Steps to reproduce the behavior

1) Break magic block until a leaves block shows up. 2) Wait.

Expected behavior

Not sure, probably for it to not decay.

Screenshots and videos (Optional)

Environment

BentoBox Version (Mandatory)

[14:58:58] [main/INFO]: [CHAT] Running PAPER 1.15.2.
[14:58:58] [main/INFO]: [CHAT] BentoBox version: 1.12.0
[14:58:58] [main/INFO]: [CHAT] Database: JSON
[14:58:58] [main/INFO]: [CHAT] Loaded Game Worlds:
[14:58:58] [main/INFO]: [CHAT] acidisland_world (AcidIsland): Overworld, Nether, The End
[14:58:58] [main/INFO]: [CHAT] bskyblock_world (BSkyBlock): Overworld, Nether, The End
[14:58:58] [main/INFO]: [CHAT] cavesblock-world (CaveBlock): Overworld, Nether, The End
[14:58:58] [main/INFO]: [CHAT] oneblock_world (OneBlock): Overworld, Nether*
[14:58:58] [main/INFO]: [CHAT] skygrid-world (SkyGrid): Overworld, Nether, The End
[14:58:58] [main/INFO]: [CHAT] Loaded Addons:
[14:58:58] [main/INFO]: [CHAT] AcidIsland 1.12.0 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] AOneBlock 1.1.5 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] Biomes 1.6.0.1 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] Border 1.0.6 (DISABLED)
[14:58:58] [main/INFO]: [CHAT] BSkyBlock 1.12.0 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] CaveBlock 1.11.0 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] Challenges 0.8.0 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] Chat 1.0.4 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] ControlPanel 1.7.0 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] DimensionalTrees 1.6.0 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] Greenhouses 1.0.0 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] Level 1.9.3 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] Likes 1.7.0 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] MagicCobblestoneGenerator 1.7.0.2 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] SkyGrid 1.11.2 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] TwerkingForTrees 1.3.0 (ENABLED)
[14:58:58] [main/INFO]: [CHAT] Warps 1.9.0 (ENABLED)

Plugins (Optional)

Plugins (30): AsyncWorldEdit, AutoPickup, BentoBox, ClearLag, CoreProtect, DeluxeChat, DiscordSRV, Essentials, EssentialsChat, EssentialsGeoIP, EssentialsSpawn, FabledSkyBlock, FeatherBoard*, HolographicDisplays, LeaderHeadsRevamped, LuckPerms, mcMMO, Multiverse-Core, Multiverse-Inventories, MVdWPlaceholderAPI*, PlaceholderAPI, PlugMan, ServerSigns, TransmuteIt, Vault, ViaBackwards, ViaRewind, ViaVersion, WorldEdit, WorldGuard

Additional context (Optional)

[Chew]

Not game breaking, as you can place a block and mine it and it'll work just fine. But what if you can't place a block?

[Poslovitch]

There are two fixes for this:

1. Make the leaves block persistent when generating it. See Leaves#setPersistent(boolean).
2. Listen to LeavesDecayEvent and cancel it (just be wary with that one, as BentoBox also handles it here).

[tastybento]

I will make them not decay, but just FYI there is a fail safe which is to die. You then get a cobblestone block. :-)

[Chew]

Ah cool, built in failsafe then :)

[tastybento]

f1a6fa340974801910ecbca430be894fde4dbe88 Done.