BentoBoxWorld / AOneBlock

A OneBlock Minecraft Game for BentoBox
https://docs.bentobox.world
Eclipse Public License 2.0
77 stars 29 forks source link

chests saving as empty/filled with air #75

Closed kMagic142 closed 4 years ago

kMagic142 commented 4 years ago

Description

Describe the bug

Chests are saving filled with AIR in oneblocks.yml.

Steps to reproduce the behavior

It happened twice to me. First time I wasted 2 hours filling chests and setting them to be as I wanted, and at the end I checked the oneblocks.yml file and all the chests we're filled with AIR instead of the items I had in the chests. This time, happened exactly the same, but the weird thing about it is that SOME chests don't save filled with air, except, they are exactly as I saved them.

Expected behavior

I don't exactly know, but the thing I know is that this should not happen.

Screenshots and videos (Optional)

Environment

BentoBox Version (Mandatory)
[12:50:40 INFO]: Running Invalid 1.15.2.
[12:50:40 INFO]: BentoBox version: 1.13.1
[12:50:40 INFO]: Database: JSON
[12:50:40 INFO]: Loaded Game Worlds:
[12:50:40 INFO]: oneblock_world (OneBlock): Overworld, Nether*
[12:50:40 INFO]: Loaded Addons:
[12:50:40 INFO]: AOneBlock 1.2.0 (ENABLED)
[12:50:40 INFO]: BentoBox-InvSwitcher 1.6.1 (ENABLED)
[12:50:40 INFO]: Biomes 1.7.0 (ENABLED)
[12:50:40 INFO]: Border 1.0.7 (DISABLED)
[12:50:40 INFO]: Challenges 0.8.2 (ENABLED)
[12:50:40 INFO]: Chat 1.0.5 (ENABLED)
[12:50:40 INFO]: ControlPanel 1.7.0 (ENABLED)
[12:50:40 INFO]: DimensionalTrees 1.6.0 (ENABLED)
[12:50:40 INFO]: IslandFly 1.7.3 (ENABLED)
[12:50:40 INFO]: Level 2.0.0 (ENABLED)
[12:50:40 INFO]: Limits 1.12.2 (ENABLED)
[12:50:40 INFO]: MagicCobblestoneGenerator 1.7.0.2 (ENABLED)
[12:50:40 INFO]: Warps 1.9.3 (ENABLED)

Plugins (Optional)

[16:36:03 INFO]: Plugins (51): AdvancedOreGen, AntiDisconnectSpam, BCommons*, BentoBox, BlockParticles, Citizens, CitizensCMD, ClearLag, CombatLogX, ConsoleSpamFix, Core*, CrazyAuctions, CrazyCrates, CustomSkinsManager, DeluxeChat, DeluxeMenus, Essentials, EssentialsSpawn, FeatherBoard*, FiguresFix*, GAListener*, HideAchievements*, HideStream*, HolographicDisplays, IPWhitelist*, JoinItems115*, JumpPads, LagAssist, LeaderHeadsRevamped, LiteBans, LuckPerms, MineableSpawners, MobFarmManager, Multiverse-Core*, MVdWPlaceholderAPI*, MyCommand, PlaceholderAPI, ProtocolLib, ShopGUIPlus, TAB, TimedRewards*, TpLogin*, TradeMe, TreysCommandBlocker*, UPotions, Vault, VoteParty, Votifier, WorldEdit, WorldGuard, YourLilMagicItems*

Additional context (Optional)

I closed this issue yesterday because I thought the problem was from me not updating the addon. Turns out that I was wrong, and the issue still occurs, but not frequently. It seems that most of the chest that I set in game are saved as they were, but some of them save filled with air. I don't know what would be the cause of this problem, but I'm open to help with finding out and solving it.

tastybento commented 4 years ago

Can you give me some steps that you are using? Like what you filled the chests with and what commands you used? Any ideas about the items in the chests? Unusual ones? How about the chest types? Epic, etc?

kMagic142 commented 4 years ago

Can you give me some steps that you are using? Like what you filled the chests with and what commands you used? Any ideas about the items in the chests? Unusual ones? How about the chest types? Epic, etc?

The command I used is /oba (or isa as I set it in the config) setchest PLAINS Common I didn't use any special items, just some flowers, saplings, seeds, flower pots and nothing too special, just vanilla minecraft things to match the theme of the phase. As when it comes to rarity, I noticed that mostly the COMMON and UNCOMMON types are saving as AIR. Also, there are some items that save normally along them, like dandelion and poppy.

tastybento commented 4 years ago

When you run that command, can you confirm that you are looking at the chest that you want to save?

kMagic142 commented 4 years ago

When you run that command, can you confirm that you are looking at the chest that you want to save?

Yes. I am looking at a chest while running that command.

tastybento commented 4 years ago

I'm having trouble replicating this right now. Can you share the .yml file that shows the chests? If you can find a specific item that causes the problem, that'd be useful too.

kMagic142 commented 4 years ago

I'm having trouble replicating this right now. Can you share the .yml file that shows the chests? If you can find a specific item that causes the problem, that'd be useful too.

Sorry for the late response, I've been busy with work for the past day. Here are the contents of the .yml file: https://pastebin.com/uEm3Y8it

Also, I'll try to find a specific item and reply when I'm done.

tastybento commented 4 years ago

That's a good clue. The item stacks are literally AIR. Huh. What server are you using specifically? i.e., where did you get it from or did you build it?

kMagic142 commented 4 years ago

That's a good clue. The item stacks are literally AIR. Huh. What server are you using specifically? i.e., where did you get it from or did you build it?

The server I'm using is built by me, with some custom plugins. The spigot I'm using is 1.15.2 Tuinity, which is a fork of Paper.

I checked if these plugins are somehow interfering with BentoBox or could be a cause to the items saving as AIR, but the results where negative. No other plugins that are on that server are connected to this problem.

I also tried on a local server with the same spigot version, with only necessary plugins, and this problem appeared again.

I think it might be a problem with 1.15.2 Tuinity, but I want you to confirm that to be sure.

tastybento commented 4 years ago

Please try Build 96 or later: https://ci.codemc.io/job/BentoBoxWorld/job/AOneBlock/

See if you can still replicate the issue.

kMagic142 commented 4 years ago

Please try Build 96 or later: https://ci.codemc.io/job/BentoBoxWorld/job/AOneBlock/

See if you can still replicate the issue.

So I tried this version just now. It seems that I can only run the command when looking at a fully filled chest, but if there is even one item missing from the chest being filled, it won't let me. This is the error:

But either than that, I cannot replicate the issue so far.

https://pastebin.com/iRuZ0gW9

tastybento commented 4 years ago

Okay, fixed. Please try the latest build.

kMagic142 commented 4 years ago

Okay, fixed. Please try the latest build.

Seems like the problem is solved. Thank you!