search

BentoBoxWorld / AcidIsland

AcidIsland™ add-on for BentoBox
Eclipse Public License 2.0
18 stars 15 forks source link

World Generation shouldn't happen in Nether (and probably End) #149

Closed MeFisto94 closed 8 months ago

MeFisto94 commented 8 months ago

Expected behavior

When in the nether, there shouldn't be sand banks generating. There shouldn't be Nether Fortresses generating and clipping into the islands either, or even less so.

Observed/Actual behavior

Structures generate and the floor is sand (below the lava/water level)

Steps/models to reproduce

Toggle the setting to allow for BentoBox/AI to use the regular terrain generation instead of a void world. This works as expected in the overworld, but it's application in the nether feels weird.

BentoBox version

[00:50:43 INFO]: Running PAPER 1.20.4. [00:50:43 INFO]: BentoBox version: 2.0.0-SNAPSHOT-b2540 [00:50:43 INFO]: Database: JSON [00:50:43 INFO]: Loaded Game Worlds: [00:50:43 INFO]: islands (AcidIsland): Overworld, Nether, The End [00:50:43 INFO]: Loaded Addons: [00:50:43 INFO]: AcidIsland 1.18.2 (ENABLED) [00:50:43 INFO]: Challenges 1.3.0-SNAPSHOT-b539 (ENABLED) [00:50:43 INFO]: ControlPanel 1.13.1-SNAPSHOT-b61 (ENABLED) [00:50:43 INFO]: Level 2.12.0 (ENABLED)

Plugin list

No response

Other

No response

tastybento commented 8 months ago

So... it's not really a bug in that the sea bottom is supposed to be there, although I suppose the blocks could be nether rack for the Nether and End stone for the End. In regards to structures, those are turned on, but I could provide a config to turn them off. I'll investigate some more.

tastybento commented 8 months ago

Okay, I've made some changes. Feedback welcome. You can try the AcidIsland snapshot at ci.bentobox.world

MeFisto94 commented 7 months ago

Hey, sorry for the late feedback. Indeed the changes work for me! Also, reflecting again, I realized it is indeed much more about a feature request than an actual bug. Maybe to elaborate a bit (as maybe those options are interesting per-world): For the overworld, I really like the generation of the amethyst caves. There are no structures that are otherwise generated. I guess this may be a coincidence of biome and what structures are generated? i.e. no villages?

For the nether, though, islands generated in the midst of nether bastions/fortresses, essentially making this setting useless for me.

So, indeed, this is fixed, but potentially one may want to differ on a per world basis, but I guess for me caves: yes and structures: no, should work.

Thanks for the fast fix!