search

BentoBoxWorld / AcidIsland

AcidIsland™ add-on for BentoBox
Eclipse Public License 2.0
18 stars 15 forks source link

Change damage type to MELTING #25

Open TheWranger opened 5 years ago

TheWranger commented 5 years ago

Is your feature request related to a problem? Please describe. It can be hard to set up death messages specifically for acid if we have other plugins killing players and using the CUSTOM damage type.

Describe the solution you'd like I suggest that this be changed to MELTING so that it can be easier to specifically set up death messages for acid and acid rain without getting in the way of other plugins.

Describe alternatives you've considered Option in the config to change the damage type

Additional context https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/browse/src/main/java/org/bukkit/event/entity/EntityDamageEvent.java#280

tastybento commented 5 years ago

Sounds like a good idea. By the way, how do you set up the messages? Is that another plugin?

TheWranger commented 5 years ago

Different plugin, DeathMessagesPrime is a commonly used one and is considered to be the best; https://www.spigotmc.org/resources/deathmessagesprime.3789/

tastybento commented 5 years ago

I did some investigation and I do not see a way to do this with the Bukkit API. If anyone else knows how to set custom DamageCause to player damage, let me know!

tastybento commented 4 years ago

There is a PR to Spigot open to enable this, but it's not accepted yet. https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/pull-requests/469/overview