Blueprint name colors are parsed incorrectly

BentoBoxWorld / BSkyBlock

BSkyBlock add-on for BentoBox (Discord link: https://discordapp.com/invite/T5HxmvK)

https://bentobox.world

Eclipse Public License 2.0

132 stars 52 forks source link

Blueprint name colors are parsed incorrectly #213

Closed NotMyFault closed 5 years ago

NotMyFault commented 5 years ago

Description

Describe the bug

The color codes in the default.json blueprint are not translated to proper colors ingame https://github.com/BentoBoxWorld/BSkyBlock/blob/8917a1d4dbd927ffc1845f6bde09f84d16f3708b/src/main/resources/blueprints/default.json#L4-L9 results in It colors them correctly, yet it also contains one of those ugly chars.

Steps to reproduce the behavior

Install the BSkyBlock addon and run /is

Screenshots and videos

Already posted above

Expected behavior

Either strip them completely (like in the other files) or a solution to translate them properly would do it.

Environment

Server

OS: Linux 3.10.0-693.11.6.el7.x86_64
Java version: OpenJDK 64-Bit Server VM 25.212-b01

Plugins

BentoBox setup

BentoBox and Addons

Configuration

Database: JSON

Additional context

Poslovitch commented 5 years ago

Might actually be à BentoBox issue as well. Shouldn't we do some prévention code international Bbox @tastybento ?

NotMyFault commented 5 years ago

I could not find a similar case where colors are not parsed correctly, so I quoted it on here, but since this is just an addon, bbox might be the root cause.

tastybento commented 5 years ago

There must be something else going on here because I don't see this issue.

What happens if you change the § to &? The § character is a native Bukkit color code that we don't touch or strip. Usually we use & because it's easier to type.

NotMyFault commented 5 years ago

That happens with &, I'm wondering which version you are on or how your default.json values are named. Odd that it only happens to me.

tastybento commented 5 years ago

I'll fix the translation of & and let's see if that helps. I am using the latest version of everything.

NotMyFault commented 5 years ago

I'll fix the translation of & and let's see if that helps. I am using the latest version of everything.

Yeah, I just setup a new server and got both from the CI. I gave it a shot with Paper and Spigot, no luck tho.

tastybento commented 5 years ago

What client are you using? And what locale? I see this at the bottom of the description:

NotMyFault commented 5 years ago

Locale default, that's just the extended NBT info if you enabled F3+H

tastybento commented 5 years ago

okay, well, try the new build once it's ready on the CI - use the default.json that has &'s in it instead of §. Let's see if that matters.

NotMyFault commented 5 years ago

Yeah, the latest changes resolved it. Nice one, thanks ;p