search

BentoBoxWorld / BSkyBlock

BSkyBlock add-on for BentoBox (Discord link: https://discordapp.com/invite/T5HxmvK)
https://bentobox.world
Eclipse Public License 2.0
131 stars 52 forks source link

Deleting island permission issue #480

Closed x1p closed 2 years ago

x1p commented 2 years ago

Expected behavior

A staff member tried to delete an island by executing bsb delete NameOfPlayer The command was not accepted. Checking the permissions, it checks for the appropriate permission.

[14:56:47] [luckperms-worker-2/INFO]: [LP] VB > Staff_member123- bskyblock.admin.delete - true
[14:56:47] [luckperms-worker-2/INFO]: [LP] VB > Staff_member123- bskyblock.admin.* - undefined

So the question is: why does a staff member needs admin.* too in order to delete an island?

Observed/Actual behavior

Message:

You don't have the permission to execute this command
(bskyblock.admin.*).

Steps/models to reproduce

Make island Execute: /bsb delete MyPlayerName See message

BentoBox version

[15:42:06 INFO]: Running PURPUR Invalid . [15:42:06 INFO]: BentoBox-versie: 1.21.0-SNAPSHOT-b2282 [15:42:06 INFO]: Database: JSON [15:42:06 INFO]: Geladen spelwerelden: [15:42:06 INFO]: bskyblock_world (BSkyBlock ): Overworld, Nether, TheEnd [15:42:06 INFO]: Loaded add-ons: [15:42:06 INFO]: Biomes 2.1.0-SNAPSHOT-b225 (ENABLED ) [15:42:06 INFO]: BSkyBlock 1.15.2-SNAPSHOT-b718 (ENABLED ) [15:42:06 INFO]: Challenges 1.1.0-SNAPSHOT-b486 (ENABLED ) [15:42:06 INFO]: Level 2.9.1-SNAPSHOT-b505 (ENABLED ) [15:42:06 INFO]: Limits 1.19.1-SNAPSHOT-b295 (ENABLED ) [15:42:06 INFO]: MagicCobblestoneGenerator 2.5.0-SNAPSHOT-b246 (ENABLED ) [15:42:06 INFO]: Warps 1.13.0-SNAPSHOT-b325 (ENABLED )

Plugin list

No response

Other

No response

BONNe commented 2 years ago

Fixed in build#2283.

Permission check requires parent command permission. In case of delete, player must have: bskyblock.admin and bskyblock.admin.delete commands.

bskyblock.admin is required to access admin main command, bskyblock.admin.delete is required to access delete command.