search

BentoBoxWorld / Bank

Allow your players to deposit and withdraw money from the island's bank! See island rankings!
Eclipse Public License 2.0
2 stars 6 forks source link

Money dupe by bank addon #41

Closed naikyys closed 1 year ago

naikyys commented 1 year ago

Expected behavior

I dont understand this section, but im expected to see no money dupe.

Observed/Actual behavior

That someone duped money by bank addon. They just used many commands of deposit and withdraw and it looks like its duplicating money, idk how its working.

Steps/models to reproduce

Bind commands of deposit and withdraw to ob bank and try to do it in one second, thats how it looks like from latest.log.

Here is the log of the problem player: https://paste.md-5.net/lukomeseqo

BentoBox version

https://i.imgur.com/SEJnQHi.png

Plugin list

No response

Other

No response

tastybento commented 1 year ago

I added a cooldown - default 1 minute to both withdraw and deposit commands. If that still can be exploited, then more drastic changes may be required. You can download the snapshot from https://ci.codemc.io/job/BentoBoxWorld/job/Bank/ and just replace your current Bank jar. If you want to change the cooldown time look in Bank's config.yml.

tastybento commented 1 year ago

I released 1.7.0. If you still find issues let me know and I can improve it.