BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
337 stars 140 forks source link

PvP global setting #1053

Open PhanaticD opened 4 years ago

PhanaticD commented 4 years ago

Description

Is your feature request related to a problem?

Currently pvp seems to not have a global setting for the world available anywhere, I would like this to be able to be set, whether it be in the config or the world flags GUI

Describe the solution you'd like us to implement.

Describe alternatives you've considered.

Additional context

PhanaticD commented 4 years ago

also I am curious if I set it to enabled, would it overwrite any existing island settings

Poslovitch commented 4 years ago

also I am curious if I set it to enabled, would it overwrite any existing island settings

I personally think it should override the existing island settings (regarding PVP), and maybe even prevent them from being edited... But that'd be prone to confusion - and that'd require an addition to the Flags API.

Any thoughts about this @tastybento ?

tastybento commented 4 years ago

Can't you just set the default island settings for PVP to true and then reset the island settings?

# These are the default settings for new islands
  default-island-settings:
    PVP_END: true
    PVP_NETHER: true
    ANIMAL_SPAWN: true
    MONSTER_SPAWN: true
    FIRE_SPREAD: true
    PVP_OVERWORLD: true

and then:

bsb resetflags PVP_OVERWORLD
bsb resetflags PVP_NETHER
bsb resetflags PVP_END
PhanaticD commented 4 years ago

no, because i need pvp enabled in areas that are not part of a island

tastybento commented 4 years ago

Okay. I understand now. It's actually a world setting for PVP outside of what islands have.

astirling commented 4 years ago

I just want to add, I'd love to see this feature also. We're trying to setup an anarchy SB and can not get PVP to work outside the island protection ranges in the bskyblock_world. I see global settings for most things, but PVP, in the configuration. docs.bentobox.world is quite lacking in documentation, so I found myself here.